Any good in pve and pvp?
Warrior is good in both, altho for pve it is better a tank than a DPS, it's even the best tank for pve,
Pros/Cons?
cons: energy limited, defensives are on same resource as attacking requires compared to other classes have it all for free.
pros: strong burst dmg, very resistand compared to other classes in dps spec. great self heal. much control thanks to leap, harpoon, headbutt.
Is it "best" in any aspect of game?
Best tank hands down.
Preferred as tanks or dps in astral/raid?
tank!
dps is okay'ish but it's melee. better leave the dpsing over to other classes that are completely designed to kill/dps like mages, psi's, classses with dps specs only considering pve.